New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset index of cutoff times in calculate feature matrix #198

Merged
merged 5 commits into from Aug 1, 2018

Conversation

Projects
None yet
3 participants
@WillKoehrsen
Contributor

WillKoehrsen commented Aug 1, 2018

Addresses issue where duplicated indices in cutoff_time dataframe results in duplicated rows in the feature matrix with calculate_feature_matrix. Solution is to reset the index in cutoff_time to remove the duplicates.

@codecov-io

This comment has been minimized.

codecov-io commented Aug 1, 2018

Codecov Report

Merging #198 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #198      +/-   ##
=========================================
+ Coverage   93.21%   93.3%   +0.08%     
=========================================
  Files          70      70              
  Lines        7727    7734       +7     
=========================================
+ Hits         7203    7216      +13     
+ Misses        524     518       -6
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 96.98% <100%> (ø) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.26% <100%> (ø) ⬆️
featuretools/primitives/binary_transform.py 90.75% <0%> (+3.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee25b59...72c370d. Read the comment docs.

@kmax12 kmax12 changed the title from Cfm reset index to Reset index of cutoff times in calculate feature matrix Aug 1, 2018

@kmax12

This comment has been minimized.

Member

kmax12 commented Aug 1, 2018

Looks good. Merging!

@kmax12 kmax12 merged commit 0e098d7 into master Aug 1, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@kmax12 kmax12 deleted the cfm-reset-index branch Aug 15, 2018

@rwedge rwedge referenced this pull request Aug 20, 2018

Merged

v0.2.2 #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment