New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove `variable_types` from normalize entity #205

Merged
merged 3 commits into from Aug 6, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented Aug 6, 2018

This PR removes the variable_types argument from normalize_entity following the discussion in #199.

close #199

Seth-Rothschild added some commits Aug 6, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Aug 6, 2018

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files          70       70           
  Lines        7737     7737           
=======================================
  Hits         7223     7223           
  Misses        514      514
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 93.81% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190d8bc...5b3c30e. Read the comment docs.

@kmax12

This comment has been minimized.

Member

kmax12 commented Aug 6, 2018

Looks good, merging

@kmax12 kmax12 merged commit c54c0af into master Aug 6, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Seth-Rothschild Seth-Rothschild deleted the remove_variable_types_from_normalize branch Aug 10, 2018

@rwedge rwedge referenced this pull request Aug 20, 2018

Merged

v0.2.2 #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment