New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filenames from S3 for Demos #207

Merged
merged 3 commits into from Aug 14, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented Aug 10, 2018

This PR would update our CSV naming convention to use the name of the CSV on S3. I've marked it as WIP because we should consider adding a step to explicitly hunt down old file names from their csv_save_location and delete old CSVs. The current branch only downloads a new file with the new name.

Deleting old files might be a reasonable thing to do given the size of the full flight dataset.

@codecov-io

This comment has been minimized.

codecov-io commented Aug 13, 2018

Codecov Report

Merging #207 into master will increase coverage by <.01%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   93.36%   93.36%   +<.01%     
==========================================
  Files          70       70              
  Lines        7743     7744       +1     
==========================================
+ Hits         7229     7230       +1     
  Misses        514      514
Impacted Files Coverage Δ
featuretools/tests/demo_tests/test_demo_data.py 100% <100%> (ø) ⬆️
featuretools/demo/retail.py 100% <100%> (ø) ⬆️
featuretools/demo/flight.py 88.63% <66.66%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d220e...4ca0f0b. Read the comment docs.

Seth-Rothschild added some commits Aug 14, 2018

@Seth-Rothschild Seth-Rothschild changed the title from (WIP) Use filenames from S3 for Demos to Use filenames from S3 for Demos Aug 14, 2018

@rwedge

This comment has been minimized.

Contributor

rwedge commented Aug 14, 2018

Looks good to me

@rwedge rwedge merged commit f4f30e3 into master Aug 14, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Aug 20, 2018

Merged

v0.2.2 #220

@Seth-Rothschild Seth-Rothschild deleted the change_demo_filenames branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment