New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix worker memory limit to entityset size comparison #214

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
2 participants
@rwedge
Contributor

rwedge commented Aug 15, 2018

There was a bug in #208 causing featuretools to treat the current memory use of a dask worker as the workers' total usable memory when deciding if the worker had enough memory to store an EntitySet.

@rwedge rwedge changed the title from compare entityset size to worker's memory limit, not current memory use to Fix worker memory limit to entityset size comparison Aug 15, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Aug 15, 2018

Codecov Report

Merging #214 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   93.48%   93.46%   -0.03%     
==========================================
  Files          71       71              
  Lines        7757     7784      +27     
==========================================
+ Hits         7252     7275      +23     
- Misses        505      509       +4
Impacted Files Coverage Δ
featuretools/computational_backends/utils.py 94.9% <100%> (ø) ⬆️
featuretools/tests/testing_utils/cluster.py 100% <100%> (ø) ⬆️
...turetools/computational_backends/pandas_backend.py 91.29% <0%> (-0.44%) ⬇️
...tests/computational_backend/test_pandas_backend.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391a927...efae989. Read the comment docs.

@rwedge rwedge merged commit bdf7511 into master Aug 16, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Aug 20, 2018

Merged

v0.2.2 #220

@kmax12 kmax12 deleted the memory-allocation-bugfix branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment