New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agg primitives to use more efficient functions #215

Merged
merged 26 commits into from Aug 24, 2018

Conversation

Projects
None yet
2 participants
@kmax12
Member

kmax12 commented Aug 16, 2018

This pull request refactors various aggregation primitives to use more efficient functions for aggregation.

In many cases, we were using the nan handling version of numpy functions, but that is not not needed when applying to Pandas Series.

In other case, we were defining functions in python when we could use other performance optimized variants.

kmax12 added some commits Aug 14, 2018

@kmax12 kmax12 referenced this pull request Aug 16, 2018

Closed

Agg rename refactor #210

@codecov-io

This comment has been minimized.

codecov-io commented Aug 16, 2018

Codecov Report

Merging #215 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   93.61%   93.63%   +0.01%     
==========================================
  Files          71       71              
  Lines        7766     7679      -87     
==========================================
- Hits         7270     7190      -80     
+ Misses        496      489       -7
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 93.75% <ø> (-0.61%) ⬇️
featuretools/entityset/serialization.py 90.47% <ø> (-1.2%) ⬇️
featuretools/tests/entityset_tests/test_es.py 99.35% <ø> (-0.01%) ⬇️
featuretools/tests/entityset_tests/test_entity.py 100% <ø> (ø) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.28% <100%> (-0.01%) ⬇️
featuretools/primitives/aggregation_primitives.py 93.95% <100%> (+1.37%) ⬆️
.../feature_function_tests/test_transform_features.py 98.85% <100%> (ø) ⬆️
...turetools/primitives/aggregation_primitive_base.py 95.6% <100%> (+0.04%) ⬆️
...turetools/computational_backends/pandas_backend.py 92.1% <100%> (-0.26%) ⬇️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.36% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ecca5f...e3d1ea4. Read the comment docs.

kmax12 added some commits Aug 16, 2018

@kmax12 kmax12 referenced this pull request Aug 23, 2018

Closed

Removing slow indexing #212

Merge branch 'master' into agg-functions
# Conflicts:
#	featuretools/entityset/entityset.py

@kmax12 kmax12 merged commit 8462046 into master Aug 24, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Aug 28, 2018

Merged

v0.3.0 #235

@kmax12 kmax12 deleted the agg-functions branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment