New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum pandas version from 0.20.3 to 0.23.0 #216

Merged
merged 2 commits into from Aug 17, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented Aug 17, 2018

We require the observed keyword argument in pandas groupby, which is new in 0.23.0.

@Seth-Rothschild Seth-Rothschild changed the title from bump min pandas version from 0.20.3 to 0.23.0 to Bump minimum pandas version from 0.20.3 to 0.23.0 Aug 17, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Aug 17, 2018

Codecov Report

Merging #216 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   93.51%   93.54%   +0.02%     
==========================================
  Files          71       71              
  Lines        7762     7759       -3     
==========================================
- Hits         7259     7258       -1     
+ Misses        503      501       -2
Impacted Files Coverage Δ
...turetools/computational_backends/pandas_backend.py 92.36% <100%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca119c...7285feb. Read the comment docs.

@kmax12

This comment has been minimized.

Member

kmax12 commented Aug 17, 2018

Looks good to merge once tests pass

@kmax12 kmax12 merged commit f74e7c3 into master Aug 17, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Aug 20, 2018

Merged

v0.2.2 #220

@Seth-Rothschild Seth-Rothschild deleted the bump-pandas-version branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment