New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove convert_links_to_integers #219

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented Aug 17, 2018

Removes the keyword argument convert_links_to_integers from normalize entity.

Some of the last_time_index tests were using a normalization with convert_links_to_integers and sorting values, leading to a resort of the "true" values in the test.

Original ordering was

0.0, 5.0, 10.0, 15.0, 20.0, 1.0, 2.0, 3.0, 7.0, 14.0, NaN

if we convert these to range(11) and sort them according to the value in the list above, the new ordering of that range would become

0, 5, 6, 7, 1, 8, 2, 9, 3, 4, 10

which aligns exactly with the changes we had to make in true_values_lti.

The other change, changing the value in test_parent_some_missing, is really a convenience measure to ensure that it ends up second to last on the sorted list. If we put it earlier, we'll have to move all the rows instead of just one.

@codecov-io

This comment has been minimized.

codecov-io commented Aug 17, 2018

Codecov Report

Merging #219 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   93.53%   93.52%   -0.01%     
==========================================
  Files          71       71              
  Lines        7759     7749      -10     
==========================================
- Hits         7257     7247      -10     
  Misses        502      502
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 94.3% <ø> (-0.3%) ⬇️
...ools/tests/entityset_tests/test_last_time_index.py 100% <100%> (ø) ⬆️
featuretools/tests/entityset_tests/test_es.py 99.31% <100%> (ø) ⬆️
featuretools/utils/gen_utils.py 66.66% <0%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74e7c3...aca37ae. Read the comment docs.

@kmax12

This comment has been minimized.

Member

kmax12 commented Aug 20, 2018

This looks good to me!

@kmax12 kmax12 merged commit 7f6b4e3 into master Aug 20, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Seth-Rothschild Seth-Rothschild deleted the remove_convert_links_to_integers branch Aug 21, 2018

@rwedge rwedge referenced this pull request Aug 28, 2018

Merged

v0.3.0 #235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment