New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch flight CSV variables #228

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented Aug 23, 2018

Previous PR used the larger CSV when the demo=True option was selected in load_flight. This fixes that.

@codecov-io

This comment has been minimized.

codecov-io commented Aug 23, 2018

Codecov Report

Merging #228 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   93.58%   93.56%   -0.02%     
==========================================
  Files          71       71              
  Lines        7727     7727              
==========================================
- Hits         7231     7230       -1     
- Misses        496      497       +1
Impacted Files Coverage Δ
featuretools/demo/flight.py 88.63% <100%> (ø) ⬆️
featuretools/utils/gen_utils.py 64.44% <0%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f854828...7070e17. Read the comment docs.

@kmax12

This comment has been minimized.

Member

kmax12 commented Aug 23, 2018

Looks good. Merging

@kmax12 kmax12 merged commit 4970660 into master Aug 23, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Aug 28, 2018

Merged

v0.3.0 #235

@Seth-Rothschild Seth-Rothschild deleted the switch-flight-variable branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment