New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround categorical merge #231

Merged
merged 3 commits into from Aug 27, 2018

Conversation

Projects
None yet
2 participants
@kmax12
Member

kmax12 commented Aug 24, 2018

This is a workaround for a possible bug in pandas where unordered categoricals that have a different order cannot merge correctly.

An issue has been filed in the pandas repo pandas-dev/pandas#22501

@kmax12 kmax12 changed the title from Work around categorical merge to Workaround categorical merge Aug 24, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Aug 24, 2018

Codecov Report

Merging #231 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   93.62%   93.62%   +<.01%     
==========================================
  Files          71       71              
  Lines        7654     7659       +5     
==========================================
+ Hits         7166     7171       +5     
  Misses        488      488
Impacted Files Coverage Δ
...turetools/computational_backends/pandas_backend.py 92.25% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 676b7cc...942a402. Read the comment docs.

@codecov-io

This comment has been minimized.

codecov-io commented Aug 27, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@676b7cc). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #231   +/-   ##
=========================================
  Coverage          ?   93.63%           
=========================================
  Files             ?       71           
  Lines             ?     7661           
  Branches          ?        0           
=========================================
  Hits              ?     7173           
  Misses            ?      488           
  Partials          ?        0
Impacted Files Coverage Δ
...turetools/computational_backends/pandas_backend.py 92.25% <100%> (ø)
featuretools/entityset/entity.py 89.77% <100%> (ø)
featuretools/entityset/entityset.py 93.59% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 676b7cc...c439071. Read the comment docs.

@kmax12 kmax12 merged commit 81718c3 into master Aug 27, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Aug 28, 2018

Merged

v0.3.0 #235

@kmax12 kmax12 deleted the workaround-categorical-merge branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment