New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust handling when no data at a cutoff time #234

Merged
merged 2 commits into from Aug 27, 2018

Conversation

Projects
None yet
3 participants
@kmax12
Member

kmax12 commented Aug 27, 2018

This PR updates how we merge dataframes internally during feature computations.

Also added a new test case for the case this merge code now handles.

@kmax12 kmax12 changed the title from Add test case for no data at a cutoff time to More robust handling when no data at a cutoff time Aug 27, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Aug 27, 2018

Codecov Report

Merging #234 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   93.63%   93.63%   +<.01%     
==========================================
  Files          71       71              
  Lines        7661     7671      +10     
==========================================
+ Hits         7173     7183      +10     
  Misses        488      488
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 99.28% <100%> (+0.01%) ⬆️
featuretools/entityset/entityset.py 93.6% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81718c3...85b0f86. Read the comment docs.

@rwedge

This comment has been minimized.

Contributor

rwedge commented Aug 27, 2018

Looks good!

@kmax12 kmax12 merged commit c1ddf30 into master Aug 27, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Aug 28, 2018

Merged

v0.3.0 #235

@kmax12 kmax12 deleted the add-no-data-test branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment