New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Consistency of Transform Primitives #236

Merged
merged 3 commits into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@WillKoehrsen
Contributor

WillKoehrsen commented Aug 29, 2018

Due to the use of a frozenset which is an unordered Python object, the order of commutative transform primitives that used multiple columns, such as AND, could change when running Deep Feature Synthesis in different Python sessions. This behavior did not affect the feature values because the primitives are commutative. It did change the feature definitions which made comparing different sets of feature definitions a challenge.

The behavior is addressed by sorting the features used in commutative transform primitives alphabetically by name. For example, if the transform primitive AND is used with the features (columns) FLAG_A and FLAG_B the resulting feature will be AND(FLAG_A, FLAG_B).

@WillKoehrsen WillKoehrsen changed the title from Consistency of Transform Primitives to Improve Consistency of Transform Primitives Aug 29, 2018

@WillKoehrsen WillKoehrsen force-pushed the transform-stability branch from c90e721 to 2a0bd7f Aug 29, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Aug 29, 2018

Codecov Report

Merging #236 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   93.63%   93.65%   +0.01%     
==========================================
  Files          71       71              
  Lines        7671     7690      +19     
==========================================
+ Hits         7183     7202      +19     
  Misses        488      488
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 93.22% <100%> (+0.03%) ⬆️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.45% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a3bf5...2a0bd7f. Read the comment docs.

@kmax12

This comment has been minimized.

Member

kmax12 commented Aug 29, 2018

Looks good. Merging

@kmax12 kmax12 merged commit 78a5e7c into master Aug 29, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@kmax12 kmax12 referenced this pull request Sep 28, 2018

Merged

v0.3.1 #270

@WillKoehrsen WillKoehrsen deleted the transform-stability branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment