New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid stacking "expanding" primitives #238

Merged
merged 4 commits into from Sep 4, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented Sep 1, 2018

This PR prevents DFS from trying to stack on primitives which output "expanding" features. It is resolves the error from #85.

Seth-Rothschild added some commits Aug 31, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Sep 1, 2018

Codecov Report

Merging #238 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   93.64%   93.65%   +0.01%     
==========================================
  Files          71       71              
  Lines        7690     7697       +7     
==========================================
+ Hits         7201     7209       +8     
+ Misses        489      488       -1
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 93.27% <100%> (+0.05%) ⬆️
...ols/tests/feature_function_tests/test_agg_feats.py 98.55% <100%> (+0.02%) ⬆️
featuretools/utils/gen_utils.py 66.66% <0%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b34b3...06ad27a. Read the comment docs.

if primitive.expanding:
return False
for f in input_types:
if f.expanding:

This comment has been minimized.

@kmax12

kmax12 Sep 3, 2018

Member

we can move this check inside of the loop a couple lines down where we also loop over each input.

also, let's add a test case for this.

This comment has been minimized.

@Seth-Rothschild

Seth-Rothschild Sep 4, 2018

Contributor

Working on the test case.

For moving this inside the for loop, want me to also move the check for base_of_exclude which can also be placed inside the larger loop?

Seth-Rothschild added some commits Sep 4, 2018

@kmax12

This comment has been minimized.

Member

kmax12 commented Sep 4, 2018

Looks good. Merging

@kmax12 kmax12 merged commit f7a4dd3 into master Sep 4, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Seth-Rothschild Seth-Rothschild deleted the avoid-stack-expanding branch Sep 4, 2018

@kmax12 kmax12 referenced this pull request Sep 28, 2018

Merged

v0.3.1 #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment