New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Normalization Preserves Types of Copy & Additional Variables #25

Merged
merged 6 commits into from Oct 31, 2017

Conversation

Projects
None yet
3 participants
@bschreck
Contributor

bschreck commented Oct 31, 2017

This fixes a bug where variables with specific types (that are different from what would ordinarily be inferred) don't have their types carried over to a new entity upon normalization.

Say you have an entity with an Ordinal variable that is a numeric dtype under the hood, so the dataframe looks like {'ordered_values': [1,2,3]}. Then you normalize out an entity, flagging that variable to move or copy:

es.normalize_entity(base_entity, new_entity, additional_vars=['ordered_values'])
es.normalize_entity(base_entity, new_entity, copy_vars=['ordered_values'])

Before this fix, the ordered_values variable type in new_entity would be Numeric instead of Ordinal.

@kmax12

This comment has been minimized.

Member

kmax12 commented Oct 31, 2017

looks good to me

@kmax12 kmax12 merged commit edff572 into master Oct 31, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@codecov-io

This comment has been minimized.

codecov-io commented Oct 31, 2017

Codecov Report

Merging #25 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   86.85%   86.88%   +0.03%     
==========================================
  Files          73       73              
  Lines        6777     6793      +16     
==========================================
+ Hits         5886     5902      +16     
  Misses        891      891
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 86.9% <100%> (+0.05%) ⬆️
...aturetools/tests/entityset_tests/test_pandas_es.py 99.72% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0310c8f...41f5a65. Read the comment docs.

@kmax12 kmax12 deleted the copy-types-normalization branch Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment