New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up merging of aggregation primitives #250

Merged
merged 3 commits into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@kmax12
Member

kmax12 commented Sep 12, 2018

This pull request makes a minor refactor to how we calculate and then merge some aggregation primitives. By returning a series instead of a dataframe, so we can avoid a reset index.

I also noticed we don't test the trend primitive, which uses this code path, so I added another test for good measure.

fixes #252

Overall this PR simplifies code without changing any functionality.

kmax12 added some commits Sep 13, 2018

@rwedge

This comment has been minimized.

Contributor

rwedge commented Sep 19, 2018

Looks good to me!

@kmax12 kmax12 merged commit 36760c8 into master Sep 19, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@kmax12 kmax12 referenced this pull request Sep 28, 2018

Merged

v0.3.1 #270

@kmax12 kmax12 deleted the clean-agg-merge branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment