New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `is_string` utils function #260

Merged
merged 4 commits into from Sep 20, 2018

Conversation

Projects
None yet
3 participants
@Seth-Rothschild
Contributor

Seth-Rothschild commented Sep 18, 2018

This PR replaces the python2 style isinstance(value, basestring) with a utils function is_string(value). It replaces the import from past.builtins import basestring with our own function from featuretools.utils import is_string. The only other use of past.builtins is in serialization.py where we import unicode.

This is related to #255 and the associated issue #254.

@Seth-Rothschild Seth-Rothschild force-pushed the is_string_in_utils branch from aa60be9 to 8bfb59f Sep 18, 2018

Seth-Rothschild added some commits Sep 18, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Sep 18, 2018

Codecov Report

Merging #260 into master will decrease coverage by <.01%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   94.14%   94.13%   -0.01%     
==========================================
  Files          71       71              
  Lines        7632     7638       +6     
==========================================
+ Hits         7185     7190       +5     
- Misses        447      448       +1
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 93.27% <100%> (ø) ⬆️
featuretools/entityset/timedelta.py 80.71% <100%> (ø) ⬆️
featuretools/entityset/entity.py 89.77% <100%> (ø) ⬆️
featuretools/utils/api.py 100% <100%> (ø) ⬆️
featuretools/primitives/cum_transform_feature.py 97.63% <100%> (ø) ⬆️
featuretools/utils/gen_utils.py 68.62% <100%> (+1.96%) ⬆️
featuretools/utils/wrangle.py 67.88% <100%> (ø) ⬆️
featuretools/variable_types/variable.py 92.3% <100%> (ø) ⬆️
featuretools/primitives/utils.py 85.36% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c357b...2b02216. Read the comment docs.

@kmax12 kmax12 changed the title from Add `is_string` utils function to (WIP) Add `is_string` utils function Sep 18, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Sep 18, 2018

Codecov Report

Merging #260 into master will increase coverage by <.01%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   94.14%   94.14%   +<.01%     
==========================================
  Files          71       71              
  Lines        7632     7638       +6     
==========================================
+ Hits         7185     7191       +6     
  Misses        447      447
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 93.27% <100%> (ø) ⬆️
featuretools/entityset/timedelta.py 80.71% <100%> (ø) ⬆️
featuretools/entityset/entity.py 89.77% <100%> (ø) ⬆️
featuretools/utils/api.py 100% <100%> (ø) ⬆️
featuretools/primitives/cum_transform_feature.py 97.63% <100%> (ø) ⬆️
featuretools/utils/gen_utils.py 70.58% <100%> (+3.92%) ⬆️
featuretools/utils/wrangle.py 67.88% <100%> (ø) ⬆️
featuretools/variable_types/variable.py 92.3% <100%> (ø) ⬆️
featuretools/primitives/utils.py 85.36% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c357b...afa5052. Read the comment docs.

@Seth-Rothschild Seth-Rothschild changed the title from (WIP) Add `is_string` utils function to Add `is_string` utils function Sep 19, 2018

@kmax12

This comment has been minimized.

Member

kmax12 commented Sep 20, 2018

Looks good. merging

@kmax12 kmax12 merged commit 6306975 into master Sep 20, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Seth-Rothschild Seth-Rothschild deleted the is_string_in_utils branch Sep 20, 2018

@kmax12 kmax12 referenced this pull request Sep 28, 2018

Merged

v0.3.1 #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment