New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling return type when creating features from DatetimeTimeIndex #266

Merged
merged 8 commits into from Sep 26, 2018

Conversation

Projects
None yet
3 participants
@kmax12
Member

kmax12 commented Sep 24, 2018

This PR fixes the issue reported in #265.

That issue surfaced as a calculation error, but the the underlying problem was incorrectly stacking features that shouldn’t exist. This PR updates the return type so the invalid feature doesn’t get created.

kmax12 added some commits Sep 24, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Sep 24, 2018

Codecov Report

Merging #266 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   94.45%   94.46%   +<.01%     
==========================================
  Files          71       71              
  Lines        7670     7690      +20     
==========================================
+ Hits         7245     7264      +19     
- Misses        425      426       +1
Impacted Files Coverage Δ
featuretools/primitives/aggregation_primitives.py 93.95% <100%> (ø) ⬆️
featuretools/primitives/primitive_base.py 90.98% <100%> (+0.14%) ⬆️
...ests/feature_function_tests/test_primitive_base.py 97.36% <100%> (+0.7%) ⬆️
featuretools/utils/gen_utils.py 68.62% <0%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3db946...479b390. Read the comment docs.

kmax12 added some commits Sep 24, 2018

@kmax12 kmax12 changed the title from (WIP) Handling return type when creating features from DatetimeTimeIndex to Handling return type when creating features from DatetimeTimeIndex Sep 24, 2018

@kmax12 kmax12 requested a review from rwedge Sep 24, 2018

@@ -96,3 +96,7 @@ def test_return_type_inference_direct_feature(es):
def test_return_type_inference_time_index(es):
last = Last(es["log"]["datetime"], es["customers"])
assert last.variable_type == Datetime
nti = NumericTimeIndex("datetime", es["log"]) # create a numeric time index variable

This comment has been minimized.

@rwedge

rwedge Sep 26, 2018

Contributor

maybe a little cleaner to make a second test using the with_integer_time_index option for make_ecommerce_entityset instead

This comment has been minimized.

@kmax12
@rwedge

This comment has been minimized.

Contributor

rwedge commented Sep 26, 2018

Looks good!

@kmax12 kmax12 merged commit ea0aee2 into master Sep 26, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@kmax12 kmax12 referenced this pull request Sep 28, 2018

Merged

v0.3.1 #270

@kmax12 kmax12 deleted the return-type branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment