New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for python 3.7 #277

Merged
merged 10 commits into from Oct 12, 2018

Conversation

Projects
None yet
4 participants
@gsheni
Contributor

gsheni commented Oct 3, 2018

  • CircleCi will now run tests in python 3.7
  • use fastparquet instead of pyarrow for tests because pyarrow does not currently support python 3.7
  • fix warning for pd.concat
  • updated test_requirements.txt package versions to most recent.
  • ignore DeprecationWarning and PendingDeprecationWarning in pytest

gsheni added some commits Oct 3, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Oct 3, 2018

Codecov Report

Merging #277 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          71       71           
  Lines        7700     7700           
=======================================
  Hits         7273     7273           
  Misses        427      427
Impacted Files Coverage Δ
...utational_backend/test_calculate_feature_matrix.py 99.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da09b20...d01acba. Read the comment docs.

@gsheni gsheni changed the title from [WIP] Update tests for python 3.7 to Update tests for python 3.7 Oct 3, 2018

@gsheni gsheni requested a review from kmax12 Oct 6, 2018

@kmax12 kmax12 requested a review from rwedge Oct 10, 2018

@@ -2,4 +2,4 @@ pytest==3.5.1
mock==2.0.0
pytest-xdist==1.20.1
pytest-cov==2.5.1

This comment has been minimized.

@rwedge

rwedge Oct 11, 2018

Contributor

Can we try updating these packages to their most recent version?

This comment has been minimized.

@gsheni

gsheni Oct 11, 2018

Contributor

Fixed.

gsheni added some commits Oct 11, 2018

@rwedge

This comment has been minimized.

Contributor

rwedge commented Oct 11, 2018

Looks good

@kmax12 kmax12 merged commit c69a9da into master Oct 12, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the python_37 branch Oct 12, 2018

@rwedge rwedge referenced this pull request Oct 31, 2018

Merged

v0.4.0 #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment