New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel verbose fixes #282

Merged
merged 4 commits into from Oct 12, 2018

Conversation

Projects
None yet
3 participants
@rwedge
Contributor

rwedge commented Oct 10, 2018

This PR adds checks to see if verbose is True before printing messages about scattering EntitySets to dask workers or persisting them on the scheduler. It also upgrades the dask and distributed package versions.

@codecov-io

This comment has been minimized.

codecov-io commented Oct 12, 2018

Codecov Report

Merging #282 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   94.44%   94.45%   +<.01%     
==========================================
  Files          71       71              
  Lines        7704     7698       -6     
==========================================
- Hits         7276     7271       -5     
+ Misses        428      427       -1
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 96.95% <ø> (-0.08%) ⬇️
featuretools/utils/gen_utils.py 70.58% <0%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69a9da...7fc879c. Read the comment docs.

@kmax12

This comment has been minimized.

Member

kmax12 commented Oct 12, 2018

Looks good to me

@kmax12 kmax12 merged commit b082f32 into master Oct 12, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the parallel_verbose_fixes branch Oct 24, 2018

@rwedge rwedge referenced this pull request Oct 31, 2018

Merged

v0.4.0 #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment