New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant relationships parameter from Entity constructor #284

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@kmax12
Member

kmax12 commented Oct 12, 2018

This PR removes the relationships parameter from Entity constructor. The information in it can be determined from the EntitySet argument, so this isn't needed.

@codecov-io

This comment has been minimized.

codecov-io commented Oct 12, 2018

Codecov Report

Merging #284 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   94.44%   94.44%   -0.01%     
==========================================
  Files          71       71              
  Lines        7704     7703       -1     
==========================================
- Hits         7276     7275       -1     
  Misses        428      428
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 93.62% <ø> (-0.02%) ⬇️
featuretools/entityset/entity.py 93.49% <100%> (ø) ⬆️
featuretools/utils/gen_utils.py 68.62% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69a9da...4d33894. Read the comment docs.

@kmax12 kmax12 requested a review from rwedge Oct 17, 2018

@rwedge

rwedge approved these changes Oct 17, 2018

Looks good

@kmax12 kmax12 merged commit 40ea5d7 into master Oct 17, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the remove-relationships-parameter branch Oct 24, 2018

@rwedge rwedge referenced this pull request Oct 31, 2018

Merged

v0.4.0 #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment