New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to fullargsspec #288

Merged
merged 7 commits into from Oct 15, 2018

Conversation

Projects
None yet
3 participants
@gsheni
Contributor

gsheni commented Oct 15, 2018

  • This fixes the following warning in python 3.7

primitives/utils.py:100
DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec()

gsheni added some commits Oct 15, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Oct 15, 2018

Codecov Report

Merging #288 into master will decrease coverage by 0.02%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
- Coverage   94.45%   94.43%   -0.03%     
==========================================
  Files          71       71              
  Lines        7698     7702       +4     
==========================================
+ Hits         7271     7273       +2     
- Misses        427      429       +2
Impacted Files Coverage Δ
featuretools/primitives/utils.py 83.72% <60%> (-1.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb9cda...f89b97b. Read the comment docs.

@gsheni gsheni requested a review from kmax12 Oct 15, 2018

gsheni added some commits Oct 15, 2018

@kmax12

This comment has been minimized.

Member

kmax12 commented Oct 15, 2018

looks good. merging

@kmax12 kmax12 merged commit c92f51c into master Oct 15, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the inspect_fix branch Oct 16, 2018

@rwedge rwedge referenced this pull request Oct 31, 2018

Merged

v0.4.0 #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment