New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up DFS arguments #319

Merged
merged 5 commits into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@kmax12
Member

kmax12 commented Nov 14, 2018

This PR does some housekeeping to the DeepFeatureSynthesis class.

No big functionality changes, but small refactors to make code more pythonic, easier to read, and easier to maintain.

kmax12 added some commits Nov 14, 2018

@codecov

This comment has been minimized.

codecov bot commented Nov 25, 2018

Codecov Report

Merging #319 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   95.21%   95.22%   +<.01%     
==========================================
  Files          71       71              
  Lines        7687     7681       -6     
==========================================
- Hits         7319     7314       -5     
+ Misses        368      367       -1
Impacted Files Coverage Δ
featuretools/synthesis/dfs.py 100% <ø> (ø) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 93.44% <100%> (-0.12%) ⬇️
featuretools/utils/gen_utils.py 88.09% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0923f...9ce554c. Read the comment docs.

@kmax12 kmax12 changed the title from (WIP) Clean up DFS arguments to Clean up DFS arguments Nov 27, 2018

@kmax12 kmax12 requested a review from rwedge Nov 27, 2018

@rwedge

rwedge approved these changes Nov 27, 2018

Looks good

@kmax12 kmax12 merged commit 68db361 into master Nov 27, 2018

3 checks passed

codecov/patch 100% of diff hit (target 95.21%)
Details
codecov/project 95.22% (+<.01%) compared to ba0923f
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Nov 29, 2018

Merged

v0.4.1 #329

@kmax12 kmax12 deleted the clean-up-dfs branch Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment