New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update properties of cumulative transform primitives #320

Merged
merged 4 commits into from Nov 26, 2018

Conversation

Projects
None yet
2 participants
@kmax12
Member

kmax12 commented Nov 14, 2018

Cumulative transform primitives had an incorrectly define property. It was named needs_all_values when it should have been uses_full_entity.

This PR fixes that and adds a test.

fixes #317 reported by @MarekHauzr

@codecov

This comment has been minimized.

codecov bot commented Nov 14, 2018

Codecov Report

Merging #320 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   95.12%   95.12%   +<.01%     
==========================================
  Files          71       71              
  Lines        7705     7714       +9     
==========================================
+ Hits         7329     7338       +9     
  Misses        376      376
Impacted Files Coverage Δ
featuretools/primitives/cum_transform_feature.py 97.63% <100%> (ø) ⬆️
.../feature_function_tests/test_transform_features.py 98.87% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4eff9...b7947ef. Read the comment docs.

@@ -617,6 +617,18 @@ def test_cum_sum_use_previous_and_where_absolute(es):
assert v == cvalues[i]
def test_cum_handles_uses_full_entity(es):
log_value_feat = es['log']['value']
for primitive in [CumSum, CumMean, CumMax, CumMax]:

This comment has been minimized.

@rwedge

rwedge Nov 26, 2018

Contributor

CumMax is in the list twice and CumCount and CumMin are not present.

This comment has been minimized.

@kmax12

kmax12 Nov 26, 2018

Member

fixed

kmax12 added some commits Nov 26, 2018

@rwedge

rwedge approved these changes Nov 26, 2018

Looks good!

@kmax12 kmax12 merged commit 65f54ac into master Nov 26, 2018

3 checks passed

codecov/patch 100% of diff hit (target 95.12%)
Details
codecov/project 95.12% (+<.01%) compared to 3d4eff9
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Nov 29, 2018

Merged

v0.4.1 #329

@kmax12 kmax12 deleted the fix-cum-primitives branch Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment