New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove casting to list in transform feature calculation #330

Merged
merged 4 commits into from Dec 7, 2018

Conversation

Projects
None yet
2 participants
@kmax12
Copy link
Member

kmax12 commented Nov 29, 2018

Removes an unnecessary casting to list.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #330 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files          74       74           
  Lines        7783     7783           
=======================================
  Hits         7416     7416           
  Misses        367      367
Impacted Files Coverage Δ
...turetools/computational_backends/pandas_backend.py 96.89% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ab0d0...80a6ad3. Read the comment docs.

@kmax12 kmax12 requested a review from rwedge Dec 3, 2018

kmax12 and others added some commits Dec 3, 2018

@rwedge

rwedge approved these changes Dec 7, 2018

Copy link
Contributor

rwedge left a comment

Looks good

@kmax12 kmax12 merged commit 9fae88b into master Dec 7, 2018

3 checks passed

codecov/patch 100% of diff hit (target 95.28%)
Details
codecov/project 95.28% (+0%) compared to 24ab0d0
Details
license/cla Contributor License Agreement is signed.
Details

@kmax12 kmax12 deleted the remove-list-casting branch Dec 7, 2018

@rwedge rwedge referenced this pull request Dec 17, 2018

Merged

v0.5.0 #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment