New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parse_date_cols parameter from EntitySet._import_from_dataframe #333

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

rwedge commented Nov 30, 2018

This keyword argument is in a private method but is never used by other Featuretools methods. All it does is add the columns to variable_types as Datetime types, but variable_types is already a parameter so they could just be included in variable_types instead.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #333 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   95.22%   95.25%   +0.02%     
==========================================
  Files          71       71              
  Lines        7692     7689       -3     
==========================================
- Hits         7325     7324       -1     
+ Misses        367      365       -2
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 95.95% <ø> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41689ce...0d85681. Read the comment docs.

@kmax12

This comment has been minimized.

Copy link
Member

kmax12 commented Nov 30, 2018

Looks good to merge

@rwedge rwedge merged commit b76056b into master Nov 30, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 41689ce...0d85681
Details
codecov/project 95.25% (+0.02%) compared to 41689ce
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge deleted the remove-parse-date-cols branch Nov 30, 2018

@rwedge rwedge referenced this pull request Dec 17, 2018

Merged

v0.5.0 #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment