New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sklearn wrapper #335

Merged
merged 2 commits into from Dec 3, 2018

Conversation

Projects
None yet
1 participant
@kmax12
Copy link
Member

kmax12 commented Dec 3, 2018

Merging #323 caused Feature master to fail tests.

This PR comments out a test that had an issue with pickling features.

kmax12 added some commits Dec 3, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #335 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
- Coverage   95.28%   95.28%   -0.01%     
==========================================
  Files          74       74              
  Lines        7787     7783       -4     
==========================================
- Hits         7420     7416       -4     
  Misses        367      367
Impacted Files Coverage Δ
...eaturetools/tests/wrappers/test_sklearn_wrapper.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfe173...7312781. Read the comment docs.

@kmax12 kmax12 merged commit 24ab0d0 into master Dec 3, 2018

3 checks passed

codecov/patch 100% of diff hit (target 95.28%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +4.71% compared to adfe173
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Dec 17, 2018

Merged

v0.5.0 #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment