New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DatetimeIndex variable conversion #342

Merged
merged 5 commits into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

gsheni commented Dec 10, 2018

gsheni added some commits Dec 10, 2018

@gsheni gsheni changed the title Fix datetime64 Fix datetime64 conversion with normalize Dec 10, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #342 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage   95.35%   95.34%   -0.01%     
==========================================
  Files          74       74              
  Lines        7791     7799       +8     
==========================================
+ Hits         7429     7436       +7     
- Misses        362      363       +1
Impacted Files Coverage Δ
featuretools/entityset/entity.py 95.65% <100%> (ø) ⬆️
featuretools/tests/entityset_tests/test_es.py 99.23% <100%> (+0.01%) ⬆️
featuretools/utils/gen_utils.py 85.71% <0%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 047aed5...e17801e. Read the comment docs.

gsheni added some commits Dec 10, 2018

@kmax12 kmax12 changed the title Fix datetime64 conversion with normalize Fix DatetimeIndex variable conversion Dec 10, 2018

@kmax12

This comment has been minimized.

Copy link
Member

kmax12 commented Dec 10, 2018

Looks good to merge

@gsheni gsheni merged commit d6fda39 into master Dec 10, 2018

3 checks passed

codecov/patch 100% of diff hit (target 95.35%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +4.64% compared to 047aed5
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the fix_datetime64 branch Dec 10, 2018

@rwedge rwedge referenced this pull request Dec 17, 2018

Merged

v0.5.0 #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment