New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seed features later in DFS process #357

Merged
merged 3 commits into from Jan 10, 2019

Conversation

Projects
None yet
2 participants
@kmax12
Copy link
Member

kmax12 commented Dec 19, 2018

Currently we add the seed features to our running list of synthesized features at the beginning of DFS.

This PR moves seed features so they get added when the other identity features for a particular are added.

This prevents a seed feature from being stacked on prematurely, creating meaningless features

For example, before this PR the following feature would get created for the customer entity when customers.COUNT(sessions) is a seed feature

LAST(sessions.customers.COUNT(sessions))

kmax12 added some commits Dec 19, 2018

@kmax12 kmax12 requested a review from gsheni Dec 19, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #357 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   95.32%   95.33%   +<.01%     
==========================================
  Files          86       86              
  Lines        8027     8032       +5     
==========================================
+ Hits         7652     7657       +5     
  Misses        375      375
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 93.46% <100%> (ø) ⬆️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.48% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775879a...74f49eb. Read the comment docs.

@gsheni

gsheni approved these changes Jan 10, 2019

Copy link
Contributor

gsheni left a comment

looks good

@kmax12 kmax12 merged commit d5845d3 into master Jan 10, 2019

3 checks passed

codecov/patch 100% of diff hit (target 95.32%)
Details
codecov/project 95.33% (+<.01%) compared to 775879a
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Jan 30, 2019

Merged

v0.6.0 #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment