New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use circleci docker images on circleci #360

Merged
merged 3 commits into from Dec 21, 2018

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

rwedge commented Dec 20, 2018

Since we no longer use tox for testing this PR switches to using a different docker image for each set of tests to match the version of python being tested.

rwedge added some commits Dec 20, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #360 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
- Coverage   95.32%   95.31%   -0.02%     
==========================================
  Files          86       86              
  Lines        8027     8027              
==========================================
- Hits         7652     7651       -1     
- Misses        375      376       +1
Impacted Files Coverage Δ
featuretools/utils/gen_utils.py 85.71% <0%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5592d05...859ff48. Read the comment docs.

@kmax12

This comment has been minimized.

Copy link
Member

kmax12 commented Dec 21, 2018

This looks good me

@rwedge rwedge changed the title use circleci docker images use circleci docker images on circleci Dec 21, 2018

@rwedge rwedge merged commit 2545244 into master Dec 21, 2018

2 of 3 checks passed

codecov/project 95.31% (-0.02%) compared to 5592d05
Details
codecov/patch Coverage not affected when comparing 5592d05...859ff48
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Jan 30, 2019

Merged

v0.6.0 #387

@rwedge rwedge deleted the swap-circleci-images branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment