New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZipCode Variable Type #367

Merged
merged 24 commits into from Jan 25, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

gsheni commented Jan 9, 2019

  • This adds a zipcode variable type
  • Fixed some import statement order and spacing

@gsheni gsheni self-assigned this Jan 9, 2019

gsheni and others added some commits Jan 15, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #367 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   95.75%   95.79%   +0.04%     
==========================================
  Files          89       89              
  Lines        7751     7754       +3     
==========================================
+ Hits         7422     7428       +6     
+ Misses        329      326       -3
Impacted Files Coverage Δ
featuretools/computational_backends/utils.py 94.9% <ø> (ø) ⬆️
featuretools/tests/dfs_tests/test_dfs_method.py 98.41% <ø> (ø) ⬆️
featuretools/tests/testing_utils/mock_ds.py 87.5% <100%> (+0.09%) ⬆️
featuretools/variable_types/variable.py 97% <100%> (+0.06%) ⬆️
featuretools/entityset/entity.py 95.65% <0%> (ø) ⬆️
...aturetools/primitives/standard/binary_transform.py 98.89% <0%> (+1.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f78c98...71bb679. Read the comment docs.

gsheni and others added some commits Jan 15, 2019

@kmax12 kmax12 force-pushed the add_zipcode branch from d78c6b8 to 0330452 Jan 21, 2019

@kmax12

This comment has been minimized.

Copy link
Member

kmax12 commented Jan 21, 2019

@gsheni can you add this new variable type to the api reference? after that, good to merge

@gsheni

This comment has been minimized.

Copy link
Contributor Author

gsheni commented Jan 24, 2019

@kmax12 Added to the api_reference.rst
Also, added zipcode column to mock_ds

gsheni added some commits Jan 24, 2019

@gsheni gsheni changed the title Update variable.py Add ZipCode Variable Type Jan 24, 2019

gsheni and others added some commits Jan 24, 2019

@kmax12

This comment has been minimized.

Copy link
Member

kmax12 commented Jan 25, 2019

Looks good to merge

@gsheni gsheni merged commit 0bb7b29 into master Jan 25, 2019

3 checks passed

codecov/patch 100% of diff hit (target 95.75%)
Details
codecov/project 95.79% (+0.04%) compared to 7f78c98
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the add_zipcode branch Jan 25, 2019

@rwedge rwedge referenced this pull request Jan 30, 2019

Merged

v0.6.0 #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment