New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testing heading to readme #373

Merged
merged 6 commits into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@RogerTangos
Copy link
Contributor

RogerTangos commented Jan 15, 2019

  • add testing instructions to readme
  • apparently... also remove a blank space at the end of a paragraph. (Sorry about that. It's a linter thing.)

Related to #371

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #373 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          89       89           
  Lines        7798     7798           
=======================================
  Hits         7475     7475           
  Misses        323      323

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6230e...8c057de. Read the comment docs.

README.md Outdated
@@ -78,6 +78,13 @@ In this demonstration, we use a multi-table dataset of 3 million online grocery

For more examples of how to use Featuretools, check out our [demos](https://www.featuretools.com/demos) page.

## Testing

This comment has been minimized.

@kmax12

kmax12 Jan 16, 2019

Member

These instructions should get added to the development section in the install page (https://docs.featuretools.com/getting_started/install.html#development).

You can create a development section in the readme and like to that url too.

This comment has been minimized.

@RogerTangos

RogerTangos Jan 29, 2019

Author Contributor

Ah. I hadn't looked in the docs, and had checked the readme instead. To avoid duplication, would it make sense just to link from the readme to the docs url?

This comment has been minimized.

@kmax12

kmax12 Jan 29, 2019

Member

that sounds good to me

RogerTangos added some commits Jan 30, 2019

@RogerTangos

This comment has been minimized.

Copy link
Contributor Author

RogerTangos commented Jan 30, 2019

Pushed. Python tests will fail likely fail because of the pandas 0.24.0 and linter update, but no code has changed. Should be good to merge.

RogerTangos and others added some commits Jan 30, 2019

@kmax12

This comment has been minimized.

Copy link
Member

kmax12 commented Jan 30, 2019

Made one change to the capitalization of Featurefools. Otherwise, looks good. Thanks!

@kmax12 kmax12 merged commit f7386e2 into Featuretools:master Jan 30, 2019

1 check passed

license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Jan 30, 2019

Merged

v0.6.0 #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment