New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pandas version to 0.23 until tests support 0.24 #383

Merged
merged 6 commits into from Jan 29, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

rwedge commented Jan 29, 2019

Pandas released version 0.24.0 recently. This PR contains some bugfixes to the tests to make the code more compatible with the new pandas version. The way featuretools implements the LatLong type is incompatible with 0.24 currently (see pandas issue #24986) so until that situation is resolved we're restricting featuretools to pandas 0.23. Pandas 0.24 should work excluding latlongs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #383 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
- Coverage   95.79%   95.75%   -0.04%     
==========================================
  Files          89       89              
  Lines        7754     7755       +1     
==========================================
- Hits         7428     7426       -2     
- Misses        326      329       +3
Impacted Files Coverage Δ
featuretools/tests/utils_tests/test_time_utils.py 94.28% <100%> (ø) ⬆️
...computational_backends/calculate_feature_matrix.py 96.98% <100%> (+0.01%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.3% <100%> (ø) ⬆️
...aturetools/primitives/standard/binary_transform.py 97.79% <0%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb7b29...cd685c3. Read the comment docs.

@kmax12

kmax12 approved these changes Jan 29, 2019

Copy link
Member

kmax12 left a comment

Looks good to me!

@rwedge rwedge merged commit 72ac0da into master Jan 29, 2019

3 checks passed

codecov/patch 100% of diff hit (target 95.79%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +4.2% compared to 0bb7b29
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Jan 30, 2019

Merged

v0.6.0 #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment