New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test and dev requirements #386

Merged
merged 6 commits into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

gsheni commented Jan 30, 2019

  • Upgraded all pypi packages in dev, test, and setup requirements.
  • flake8, and pympler do not have their latest version on conda, so only upgraded to the latest on conda.
  • lint fixes
  • pytest threw an error that fixtures cannot be called directly, so this was fixed.

@gsheni gsheni changed the title updated pypi Update test and dev requirements Jan 30, 2019

gsheni added some commits Jan 30, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #386 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   95.77%   95.77%   +<.01%     
==========================================
  Files          90       90              
  Lines        7857     7867      +10     
==========================================
+ Hits         7525     7535      +10     
  Misses        332      332
Impacted Files Coverage Δ
featuretools/utils/gen_utils.py 88.09% <ø> (ø) ⬆️
featuretools/computational_backends/utils.py 94.9% <100%> (ø) ⬆️
featuretools/tests/testing_utils/mock_ds.py 87.5% <100%> (ø) ⬆️
...s/tests/primitive_tests/test_install_primitives.py 100% <100%> (ø) ⬆️
featuretools/entityset/entity.py 95.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db365f9...d03f3ff. Read the comment docs.

@gsheni gsheni requested a review from rwedge Jan 30, 2019



@pytest.fixture
def install_via_cl():

This comment has been minimized.

@rwedge

rwedge Jan 30, 2019

Contributor

install_via_cli

Same thing inside the parameterize list

This comment has been minimized.

@gsheni

gsheni Jan 30, 2019

Author Contributor

Fixed.

gsheni added some commits Jan 30, 2019

@rwedge

rwedge approved these changes Jan 30, 2019

Copy link
Contributor

rwedge left a comment

looks good

@rwedge rwedge merged commit fd20a39 into master Jan 30, 2019

3 checks passed

codecov/patch 100% of diff hit (target 95.77%)
Details
codecov/project 95.77% (+<.01%) compared to db365f9
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the upgrade_dev_req branch Jan 30, 2019

@rwedge rwedge referenced this pull request Jan 30, 2019

Merged

v0.6.0 #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment