Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list_primitives #391

Merged
merged 8 commits into from Feb 2, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

gsheni commented Feb 1, 2019

  • Fixed list_primitives
  • Added test case
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #391 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   95.78%   95.97%   +0.19%     
==========================================
  Files          90       91       +1     
  Lines        7882     7908      +26     
==========================================
+ Hits         7550     7590      +40     
+ Misses        332      318      -14
Impacted Files Coverage Δ
featuretools/primitives/utils.py 100% <100%> (+37.83%) ⬆️
...uretools/tests/utils_tests/test_list_primitives.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be812d8...c5b0ec7. Read the comment docs.

assert x in df['name'].values.tolist()
for x in ['aggregation', 'transform']:
assert x in df['type'].values.tolist()
chars_desc = 'Return the characters in a given string.'

This comment has been minimized.

@kmax12

kmax12 Feb 1, 2019

Member

Get the description text from the primitive object itself.

This comment has been minimized.

@gsheni

gsheni Feb 1, 2019

Author Contributor

Fixed.

chars_desc = 'Return the characters in a given string.'
day_desc = 'Transform a Datetime feature into the day.'
last_desc = 'Returns the last value.'
for x in [chars_desc] + [day_desc] + [last_desc]:

This comment has been minimized.

@kmax12

kmax12 Feb 1, 2019

Member

There could still be an out of order problem. The test should find the row of the primitive and then check the description matches

This comment has been minimized.

@gsheni

gsheni Feb 1, 2019

Author Contributor

Fixed.

@gsheni gsheni changed the title added test Fix list_primitives Feb 1, 2019

gsheni added some commits Feb 1, 2019

@kmax12

kmax12 approved these changes Feb 1, 2019



def test_descriptions():
primitives = {NumCharacters: 'Return the characters in a given string.',

This comment has been minimized.

@kmax12

kmax12 Feb 1, 2019

Member

can we add one primitive here that doesn't have a description so we can test the "" case?.

otherwise, it all looks good to merge

This comment has been minimized.

@gsheni

gsheni Feb 1, 2019

Author Contributor

Fixed.

@gsheni gsheni merged commit a22d852 into master Feb 2, 2019

3 checks passed

codecov/patch 100% of diff hit (target 95.78%)
Details
codecov/project 95.97% (+0.19%) compared to be812d8
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the list_primitive_fix branch Feb 2, 2019

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.