Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transform stacking on multi-output aggregation #394

Merged
merged 12 commits into from Feb 2, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

gsheni commented Feb 1, 2019

  • Fixes an assertion issue
  • test case to check this.

@gsheni gsheni self-assigned this Feb 1, 2019

@gsheni gsheni requested a review from rwedge Feb 1, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #394 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   95.97%   95.98%   +<.01%     
==========================================
  Files          91       91              
  Lines        7908     7916       +8     
==========================================
+ Hits         7590     7598       +8     
  Misses        318      318
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 94.5% <100%> (+0.01%) ⬆️
featuretools/feature_base/feature_base.py 96.22% <100%> (ø) ⬆️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.33% <100%> (+0.01%) ⬆️
...s/tests/primitive_tests/test_transform_features.py 98.05% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22d852...e37dc90. Read the comment docs.

@rwedge
Copy link
Contributor

rwedge left a comment

Can you also add a test case where DFS tries to stack features this way so that we hit the try-catch on codecov?

@gsheni

This comment has been minimized.

Copy link
Contributor Author

gsheni commented Feb 1, 2019

@rwedge fixed with dfs test that uses a mutli output agg and transform

gsheni added some commits Feb 1, 2019

fix
@rwedge

rwedge approved these changes Feb 2, 2019

@gsheni gsheni merged commit 6d991ad into master Feb 2, 2019

3 checks passed

codecov/patch 100% of diff hit (target 95.97%)
Details
codecov/project 95.98% (+<.01%) compared to a22d852
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the multi_stack_fix branch Feb 2, 2019

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.