Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that agg_primitives and trans_primitives are right primitive type #397

Merged
merged 4 commits into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

rwedge commented Feb 1, 2019

This PR adds a check in DFS to agg_primitives and trans_primitives to give a clearer error when primitives are included in the wrong list (putting Hour in agg_primitives, for exmaple)

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #397 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   95.96%   95.97%   +<.01%     
==========================================
  Files          91       91              
  Lines        7934     7945      +11     
==========================================
+ Hits         7614     7625      +11     
  Misses        320      320
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 94.57% <100%> (+0.06%) ⬆️
...ols/tests/dfs_tests/test_deep_feature_synthesis.py 98.37% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054da8a...5f6eeec. Read the comment docs.

@rwedge rwedge requested a review from kmax12 Feb 1, 2019

@kmax12

kmax12 approved these changes Feb 4, 2019

Copy link
Member

kmax12 left a comment

Other than one comment, looks good

@@ -681,3 +681,19 @@ def test_initialized_agg_prim(es):
trans_primitives=[])
features = dfs_obj.build_features()
assert (feature_with_name(features, "N_MOST_COMMON(log.product_id)"))


def test_checks_agg_primitives_are_aggs(es):

This comment has been minimized.

@kmax12

kmax12 Feb 4, 2019

Member

the method name should be something like test_check_primitives_correct_type

rwedge added some commits Feb 5, 2019

@rwedge rwedge merged commit 56b6f91 into master Feb 5, 2019

3 checks passed

codecov/patch 100% of diff hit (target 95.96%)
Details
codecov/project 95.97% (+<.01%) compared to 054da8a
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.