Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if graphviz backend is installed #398

Merged
merged 11 commits into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@floscha
Copy link
Contributor

floscha commented Feb 3, 2019

Based on the discussion at the bottom of #381, this PR checks if a working Graphviz backend is installed. If not, it will suggest how to do so like described here.

While #389 added similar hints for the documentation, I'm afraid most people will install the package without reading the docs and then face missing backend issues during runtime.

floscha added some commits Feb 3, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 3, 2019

Codecov Report

Merging #398 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   95.98%   95.95%   -0.03%     
==========================================
  Files          91       91              
  Lines        7916     7920       +4     
==========================================
+ Hits         7598     7600       +2     
- Misses        318      320       +2
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 93.84% <50%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9a65c...ab1a3fb. Read the comment docs.

Show resolved Hide resolved featuretools/entityset/entityset.py Outdated
Show resolved Hide resolved featuretools/entityset/entityset.py Outdated

floscha and others added some commits Feb 4, 2019

@kmax12

This comment has been minimized.

Copy link
Member

kmax12 commented Feb 4, 2019

Looks good. Merging

@kmax12 kmax12 merged commit 5370c66 into Featuretools:master Feb 4, 2019

1 of 3 checks passed

codecov/patch 50% of diff hit (target 95.98%)
Details
codecov/project 95.95% (-0.03%) compared to 3f9a65c
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.