Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comments to feature_tree #400

Merged
merged 2 commits into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@RogerTangos
Copy link
Contributor

RogerTangos commented Feb 4, 2019

  • describe what some of the instance variables are
  • Add one line break in code, bringing max line size to 100
  • rename all_features in __init__, since it's confusing to have all_features be different from self.all_features
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #400 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          91       91           
  Lines        7916     7916           
=======================================
  Hits         7598     7598           
  Misses        318      318
Impacted Files Coverage Δ
...eaturetools/computational_backends/feature_tree.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9a65c...2de7ab3. Read the comment docs.

@kmax12

This comment has been minimized.

Copy link
Member

kmax12 commented Feb 4, 2019

Looks good! I suspect more work can be done here, but need to start somewhere. Thank you for the contribution. Merging now

@kmax12 kmax12 merged commit c2c6431 into Featuretools:master Feb 4, 2019

3 checks passed

codecov/patch 100% of diff hit (target 95.98%)
Details
codecov/project 95.98% (+0%) compared to 3f9a65c
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.