Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put make lint on separate run command for circleci #402

Merged
merged 3 commits into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

rwedge commented Feb 4, 2019

Since the pip installation and linting output happen on the same set for circleci the pip output obscures the linting results, making it necessary to download the output as a file to check the linting output. This makes the lint test a separate action to make it more convenient to check.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files          91       91           
  Lines        7934     7934           
=======================================
  Hits         7614     7614           
  Misses        320      320

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7d876...ac0d771. Read the comment docs.

@rwedge rwedge requested a review from gsheni Feb 4, 2019

@gsheni

gsheni approved these changes Feb 4, 2019

rwedge added some commits Feb 4, 2019

@rwedge rwedge merged commit 054da8a into master Feb 4, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 6c7d876...ac0d771
Details
codecov/project 95.96% remains the same compared to 6c7d876
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge deleted the lint-as-separate-ci-step branch Feb 4, 2019

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.