Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install data and dependencies #403

Merged
merged 28 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

rwedge commented Feb 5, 2019

In addition to primitives files, featuretools install will now look for a folder named "data" and copy it to featuretools/primitives/data/. It will also look for "requirements.txt" and run pip install -r requirements.txt if it finds it.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #403 into master will increase coverage by 0.04%.
The diff coverage is 95.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   96.07%   96.11%   +0.04%     
==========================================
  Files          92       92              
  Lines        8023     8162     +139     
==========================================
+ Hits         7708     7845     +137     
- Misses        315      317       +2
Impacted Files Coverage Δ
featuretools/primitives/install.py 90.9% <88.88%> (+1.83%) ⬆️
...s/tests/primitive_tests/test_install_primitives.py 98.93% <98.42%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f770816...9eb5f6d. Read the comment docs.

@kmax12
Copy link
Member

kmax12 left a comment

Looking good. Should be ready to merge after my comments are addressed

directory = os.path.join(tmp_dir, os.path.dirname(members[0].path))
for member in members:
if os.path.isfile(os.path.join(tmp_dir, member.path)):
directory = os.path.join(tmp_dir, os.path.dirname(member.path))

This comment has been minimized.

@kmax12

kmax12 Feb 8, 2019

Member

should there be a break out of this loop after the directory is found?

if prompt:
while True:
resp = input("Install primitives: %s? (Y/n) " % primitives_list)
if resp == "Y":

This comment has been minimized.

@kmax12

kmax12 Feb 8, 2019

Member

should we update this to make it not case sensitive?

files_to_copy.append(filepath)
all_primitives.add(primitive_obj.name)

if all_primitives != set(info['primitives']):

This comment has been minimized.

@kmax12

kmax12 Feb 8, 2019

Member

just need to add a test for this case

for filepath in files:
primitive_name, primitive_obj = load_primitive_from_file(filepath)
if primitive_obj.name not in info['primitives']:
raise RuntimeError("Primitive %s not listed in "

This comment has been minimized.

@kmax12

kmax12 Feb 8, 2019

Member

just need to add a test for this case

rwedge and others added some commits Feb 8, 2019

@kmax12

kmax12 approved these changes Feb 8, 2019

Copy link
Member

kmax12 left a comment

LGTM

@rwedge rwedge merged commit 2273050 into master Feb 8, 2019

2 of 3 checks passed

codecov/patch 95.58% of diff hit (target 96.07%)
Details
codecov/project 96.11% (+0.04%) compared to f770816
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.