Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulative primitives #410

Merged
merged 10 commits into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@CharlesBradshaw
Copy link
Contributor

CharlesBradshaw commented Feb 6, 2019

Fixes #405

Updated cumulative primitives (Count,Sum,Max,Min,Mean) to use new primitive API

@CharlesBradshaw CharlesBradshaw requested a review from kmax12 Feb 6, 2019

CharlesBradshaw added some commits Feb 6, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #410 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   96.14%   96.24%   +0.09%     
==========================================
  Files          92       93       +1     
  Lines        8232     8434     +202     
==========================================
+ Hits         7915     8117     +202     
  Misses        317      317
Impacted Files Coverage Δ
featuretools/entityset/entity.py 95.65% <ø> (ø) ⬆️
featuretools/entityset/entityset.py 93.84% <ø> (ø) ⬆️
...tools/primitives/standard/cum_transform_feature.py 100% <100%> (ø)
...s/tests/primitive_tests/test_transform_features.py 98.51% <100%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b6e04...163ca82. Read the comment docs.

@kmax12

kmax12 approved these changes Feb 7, 2019

Copy link
Member

kmax12 left a comment

Looks good to me

kmax12 and others added some commits Feb 7, 2019

@CharlesBradshaw CharlesBradshaw merged commit d93ff0d into master Feb 11, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.14%)
Details
codecov/project 96.24% (+0.09%) compared to 69b6e04
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.