Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Variable dtype #416

Merged
merged 5 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

gsheni commented Feb 7, 2019

  • Variable dtype is unused so we are removing the functionality.

@gsheni gsheni self-assigned this Feb 7, 2019

@gsheni gsheni requested a review from kmax12 Feb 7, 2019

@@ -44,7 +44,7 @@ def __eq__(self, other):
self.entity_id == other.entity_id

def __repr__(self):
ret = u"<Variable: {} (dtype = {})>".format(self.name, self.dtype)
ret = u"<Variable: {} >".format(self.name)

This comment has been minimized.

@kmax12

kmax12 Feb 7, 2019

Member

still print the dtype, just use self._dtype_repr

This comment has been minimized.

@gsheni

gsheni Feb 7, 2019

Author Contributor

Fixed.

@@ -84,7 +84,7 @@ def __repr__(self):
repr_out = u"Entity: {}\n".format(self.id)
repr_out += u" Variables:"
for v in self.variables:
repr_out += u"\n {} (dtype: {})".format(v.id, v.dtype)
repr_out += u"\n {} ".format(v.id)

This comment has been minimized.

@kmax12

kmax12 Feb 7, 2019

Member

still print the dtype, just use self._dtype_repr

This comment has been minimized.

@gsheni

gsheni Feb 7, 2019

Author Contributor

Fixed.

def dtype(self):
return self._dtype_repr \
if self._dtype_repr is not None else "generic_type"
# @property

This comment has been minimized.

@kmax12

kmax12 Feb 7, 2019

Member

delete this

This comment has been minimized.

@gsheni

gsheni Feb 7, 2019

Author Contributor

Fixed.

gsheni added some commits Feb 7, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #416 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
- Coverage   96.07%   96.07%   -0.01%     
==========================================
  Files          92       92              
  Lines        8025     8022       -3     
==========================================
- Hits         7710     7707       -3     
  Misses        315      315
Impacted Files Coverage Δ
featuretools/entityset/entity.py 95.65% <ø> (ø) ⬆️
featuretools/variable_types/variable.py 96.93% <ø> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5923b68...0ab6863. Read the comment docs.

Fixed the issues.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #416 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
- Coverage   96.07%   96.07%   -0.01%     
==========================================
  Files          92       92              
  Lines        8025     8023       -2     
==========================================
- Hits         7710     7708       -2     
  Misses        315      315
Impacted Files Coverage Δ
featuretools/entityset/entity.py 95.65% <ø> (ø) ⬆️
featuretools/variable_types/variable.py 96.96% <ø> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5923b68...0ab6863. Read the comment docs.

@kmax12

kmax12 approved these changes Feb 8, 2019

Copy link
Member

kmax12 left a comment

LGTM

@gsheni gsheni merged commit 2204a76 into master Feb 8, 2019

2 of 3 checks passed

codecov/project 96.07% (-0.01%) compared to 5923b68
Details
codecov/patch Coverage not affected when comparing 5923b68...0ab6863
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the remove_v_dtype branch Feb 8, 2019

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.