Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to zipcode rep, str for pandas #418

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

gsheni commented Feb 7, 2019

  • Change the ZIPCode _dtype_repr to zipcode
  • Add ZIPCode _default_pandas_dtype as str

@gsheni gsheni self-assigned this Feb 7, 2019

@gsheni gsheni requested a review from kmax12 Feb 7, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #418 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   96.07%   96.07%   +<.01%     
==========================================
  Files          92       92              
  Lines        8024     8025       +1     
==========================================
+ Hits         7709     7710       +1     
  Misses        315      315
Impacted Files Coverage Δ
featuretools/variable_types/variable.py 97.02% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a3b81...3580955. Read the comment docs.

@kmax12

kmax12 approved these changes Feb 7, 2019

Copy link
Member

kmax12 left a comment

LGTM

@gsheni gsheni merged commit 5923b68 into master Feb 7, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.07%)
Details
codecov/project 96.07% (+<.01%) compared to 02a3b81
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the change_zip_code_dtype branch Feb 7, 2019

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.