Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transform_primitive.py #419

Merged
merged 6 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

gsheni commented Feb 8, 2019

  • num_words as a primitive is used as one of the dfs default args and in the docs
  • However, the primitive name is numwords so if someone does ft.dfs(trans_primitives='numwords'), it will error
  • Same thing with characters and num_characters
  • Another option is the fix the docstrings
  • This fixes this issue.

gsheni added some commits Feb 8, 2019

@gsheni gsheni self-assigned this Feb 8, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #419 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #419   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          92       92           
  Lines        8162     8162           
=======================================
  Hits         7845     7845           
  Misses        317      317
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100% <100%> (ø) ⬆️
...uretools/tests/utils_tests/test_list_primitives.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcfaca4...b101066. Read the comment docs.

@gsheni gsheni requested a review from rwedge Feb 8, 2019

gsheni added some commits Feb 8, 2019

@kmax12 kmax12 merged commit 3ed0692 into master Feb 8, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.11%)
Details
codecov/project 96.11% (+0%) compared to dcfaca4
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

@gsheni gsheni deleted the fix_num_words branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.