Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize infer_variable_type, convert_variable_data and convert_all_variable_data methods #423

Merged
merged 6 commits into from Feb 19, 2019

Conversation

Projects
None yet
2 participants
@bukosabino
Copy link
Member

commented Feb 8, 2019

@codecov

This comment has been minimized.

Copy link

commented Feb 8, 2019

Codecov Report

Merging #423 into master will increase coverage by 0.02%.
The diff coverage is 97.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   96.29%   96.32%   +0.02%     
==========================================
  Files          93       95       +2     
  Lines        8455     8514      +59     
==========================================
+ Hits         8142     8201      +59     
  Misses        313      313
Impacted Files Coverage Δ
...eaturetools/tests/utils_tests/test_entity_utils.py 100% <100%> (ø)
featuretools/entityset/entity.py 95.75% <100%> (+0.1%) ⬆️
featuretools/utils/entity_utils.py 95.78% <95.78%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16c04fe...c2ab488. Read the comment docs.

@bukosabino bukosabino referenced this pull request Feb 8, 2019

Closed

Entity utils #370

@kmax12
Copy link
Member

left a comment

some initial feedback. the test cases still need more work before this is ready to merge

Show resolved Hide resolved featuretools/utils/entity_utils.py Outdated
Show resolved Hide resolved featuretools/tests/utils_tests/test_entity_utils.py Outdated
Show resolved Hide resolved featuretools/tests/utils_tests/test_entity_utils.py Outdated
Show resolved Hide resolved featuretools/tests/utils_tests/test_entity_utils.py Outdated
Show resolved Hide resolved featuretools/entityset/entity.py
Show resolved Hide resolved featuretools/tests/utils_tests/test_entity_utils.py Outdated
Show resolved Hide resolved featuretools/tests/utils_tests/test_entity_utils.py Outdated
Show resolved Hide resolved featuretools/tests/utils_tests/test_entity_utils.py Outdated
@kmax12
Copy link
Member

left a comment

Should be ready to merge after my comments are addressed. Thanks

@kmax12
Copy link
Member

left a comment

just a couple last comments. looking good overall. thank you!

Show resolved Hide resolved featuretools/tests/utils_tests/test_entity_utils.py Outdated
Show resolved Hide resolved featuretools/tests/utils_tests/test_entity_utils.py Outdated

bukosabino and others added some commits Feb 12, 2019

@kmax12

kmax12 approved these changes Feb 13, 2019

Copy link
Member

left a comment

This ready to go. We will merge it master after the next release of Featuretools goes out, which should be this week.

@kmax12 kmax12 merged commit d4111ac into master Feb 19, 2019

3 checks passed

codecov/patch 97.35% of diff hit (target 96.29%)
Details
codecov/project 96.32% (+0.02%) compared to 16c04fe
Details
license/cla Contributor License Agreement is signed.
Details

@bukosabino bukosabino deleted the entity-utils2 branch Feb 19, 2019

@rwedge rwedge referenced this pull request Mar 29, 2019

Merged

v0.7.0 #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.