Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primitive function name uniqueness #424

Merged
merged 5 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@rwedge
Copy link
Contributor

rwedge commented Feb 8, 2019

Fixes some errors related to when multiple primitives used same aggregation function or when two features with same primitive but different parameters were applied to the same base feature.

@kmax12 kmax12 self-requested a review Feb 8, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #424 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   96.11%   96.14%   +0.03%     
==========================================
  Files          92       92              
  Lines        8162     8232      +70     
==========================================
+ Hits         7845     7915      +70     
  Misses        317      317
Impacted Files Coverage Δ
...turetools/computational_backends/pandas_backend.py 98.2% <100%> (+0.01%) ⬆️
...tests/computational_backend/test_pandas_backend.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed0692...30bc9bf. Read the comment docs.

@kmax12

kmax12 approved these changes Feb 8, 2019

Copy link
Member

kmax12 left a comment

LGTM

@rwedge rwedge merged commit 659ebf4 into master Feb 8, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.11%)
Details
codecov/project 96.14% (+0.03%) compared to 3ed0692
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.