Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ips and email address to mock ds #426

Merged
merged 8 commits into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@gsheni
Copy link
Contributor

gsheni commented Feb 11, 2019

  • Added new Variable Type, IP Address and email address
  • Added these types to mock_ds
  • Added to docs

@gsheni gsheni self-assigned this Feb 11, 2019

@gsheni gsheni requested a review from kmax12 Feb 11, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #426 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   96.24%   96.24%   +<.01%     
==========================================
  Files          93       93              
  Lines        8433     8440       +7     
==========================================
+ Hits         8116     8123       +7     
  Misses        317      317
Impacted Files Coverage Δ
featuretools/primitives/install.py 90.9% <ø> (ø) ⬆️
featuretools/tests/entityset_tests/test_entity.py 100% <100%> (ø) ⬆️
featuretools/tests/testing_utils/mock_ds.py 87.59% <100%> (+0.09%) ⬆️
featuretools/variable_types/variable.py 97.14% <100%> (+0.17%) ⬆️
featuretools/entityset/entity.py 95.65% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd8039...cb88a67. Read the comment docs.

Show resolved Hide resolved docs/source/api_reference.rst Outdated

gsheni added some commits Feb 12, 2019

@rwedge

This comment has been minimized.

Copy link
Contributor

rwedge commented Feb 12, 2019

Thematically, wouldn't IP address make more sense as as session variable and email as a customer variable?

@gsheni

This comment has been minimized.

Copy link
Contributor Author

gsheni commented Feb 12, 2019

Thematically, wouldn't IP address make more sense as as session variable and email as a customer variable?

Fixed.

gsheni added some commits Feb 12, 2019

@@ -75,10 +75,10 @@ def test_update_data(es):
es['customers'].update_data(df.drop(columns=['cohort']))
assert 'Updated dataframe is missing new cohort column' in str(excinfo)

error_text = 'Updated dataframe contains 13 columns, expecting 12'
error_text = 'Updated dataframe contains 14 columns, expecting 13'

This comment has been minimized.

@gsheni

gsheni Feb 12, 2019

Author Contributor

1 more column(email) was added to the customer's entity.

with pytest.raises(ValueError, match=error_text) as excinfo:
es['customers'].update_data(df)
assert 'Updated dataframe contains 13 columns, expecting 12' in str(excinfo)
assert 'Updated dataframe contains 14 columns, expecting 13' in str(excinfo)

This comment has been minimized.

@gsheni

gsheni Feb 12, 2019

Author Contributor

1 more column(ip) was added to the session's entity.

@kmax12

kmax12 approved these changes Feb 12, 2019

@gsheni gsheni merged commit 0a92950 into master Feb 12, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.24%)
Details
codecov/project 96.24% (+<.01%) compared to 5cd8039
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the add_ip_email branch Feb 12, 2019

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.