Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity.query_by_values now preserves row order of underlying data #428

Merged
merged 9 commits into from Feb 12, 2019

Conversation

Projects
None yet
2 participants
@CharlesBradshaw
Copy link
Contributor

CharlesBradshaw commented Feb 12, 2019

Previously the query by values didn't guarantee that the rows would be returned in the order of the original dataframe. This caused issues for cumulative primitives.

@CharlesBradshaw CharlesBradshaw requested a review from kmax12 Feb 12, 2019

@kmax12 kmax12 changed the title Entity Query by Values Now Returns Rows In Order Entity.query_by_values now preserves row order of underlying data Feb 12, 2019

@kmax12

kmax12 approved these changes Feb 12, 2019

Copy link
Member

kmax12 left a comment

Good to merge once tests pass

CharlesBradshaw added some commits Feb 12, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #428 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   96.24%   96.24%   +<.01%     
==========================================
  Files          93       93              
  Lines        8440     8447       +7     
==========================================
+ Hits         8123     8130       +7     
  Misses        317      317
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_entity.py 100% <100%> (ø) ⬆️
featuretools/entityset/entity.py 95.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a92950...b4e314e. Read the comment docs.

@CharlesBradshaw CharlesBradshaw merged commit d24b64d into master Feb 12, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.24%)
Details
codecov/project 96.24% (+<.01%) compared to 0a92950
Details
license/cla Contributor License Agreement is signed.
Details

@CharlesBradshaw CharlesBradshaw deleted the entity_shuffle_fix branch Feb 12, 2019

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.