Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calculate identity features #429

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
2 participants
@CharlesBradshaw
Copy link
Contributor

CharlesBradshaw commented Feb 12, 2019

_calculate_identity_features now only returns the features specified in the features parameter as opposed to returning all of the identity features of an entity

@CharlesBradshaw CharlesBradshaw requested a review from kmax12 Feb 12, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #429 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
- Coverage   96.24%   96.24%   -0.01%     
==========================================
  Files          93       93              
  Lines        8434     8433       -1     
==========================================
- Hits         8117     8116       -1     
  Misses        317      317
Impacted Files Coverage Δ
...turetools/computational_backends/pandas_backend.py 98.2% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93ff0d...23002ae. Read the comment docs.

@kmax12 kmax12 changed the title Patch Calculate Identity Features Update calculate identity features Feb 12, 2019

@kmax12

kmax12 approved these changes Feb 12, 2019

Copy link
Member

kmax12 left a comment

Looks good

@CharlesBradshaw CharlesBradshaw merged commit 5cd8039 into master Feb 12, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.24%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.75% compared to d93ff0d
Details
license/cla Contributor License Agreement is signed.
Details

@CharlesBradshaw CharlesBradshaw deleted the extra_identity_feature_fix branch Feb 12, 2019

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.