Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Country Code and Sub Region Codes as variable types #430

Merged
merged 10 commits into from Feb 14, 2019

Conversation

Projects
None yet
3 participants
@jxwolstenholme
Copy link
Contributor

jxwolstenholme commented Feb 12, 2019

No description provided.

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Feb 12, 2019

CLA assistant check
All committers have signed the CLA.

jxwolstenholme added some commits Feb 12, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #430 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage   96.24%   96.25%   +<.01%     
==========================================
  Files          93       93              
  Lines        8447     8455       +8     
==========================================
+ Hits         8130     8138       +8     
  Misses        317      317
Impacted Files Coverage Δ
featuretools/tests/testing_utils/mock_ds.py 87.76% <100%> (+0.17%) ⬆️
featuretools/variable_types/variable.py 97.29% <100%> (+0.15%) ⬆️
featuretools/entityset/entity.py 95.65% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f69e70...0b08f33. Read the comment docs.

@jxwolstenholme

This comment has been minimized.

Copy link
Contributor Author

jxwolstenholme commented Feb 12, 2019

Will add tests and docs

jxwolstenholme added some commits Feb 12, 2019

@kmax12
Copy link
Member

kmax12 left a comment

This is looking good. Ready to merge after my two comments are addressed. Thank you for the contribution!

Show resolved Hide resolved featuretools/variable_types/variable.py Outdated
Show resolved Hide resolved featuretools/variable_types/variable.py Outdated

jxwolstenholme added some commits Feb 12, 2019

addressing comments
changed _dtype_repr to include underscore
@kmax12

kmax12 approved these changes Feb 13, 2019

Copy link
Member

kmax12 left a comment

Looks good to me. Thank you very much for the contribution.

@kmax12 kmax12 merged commit 1998ec7 into Featuretools:master Feb 14, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.24%)
Details
codecov/project 96.25% (+<.01%) compared to 3f69e70
Details
license/cla Contributor License Agreement is signed.
Details

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.