Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed tests and plot func #433

Merged
merged 2 commits into from Feb 14, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

gsheni commented Feb 14, 2019

  • Fixes the plotting function error AttributeError: 'Index' object has no attribute 'dtype'
  • Fixes the test so that it uses an actual filled EntitySet

@gsheni gsheni self-assigned this Feb 14, 2019

@gsheni gsheni requested a review from kmax12 Feb 14, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #433 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   96.25%   96.33%   +0.08%     
==========================================
  Files          93       93              
  Lines        8455     8450       -5     
==========================================
+ Hits         8138     8140       +2     
+ Misses        317      310       -7
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 95.23% <100%> (+1.38%) ⬆️
...eaturetools/tests/entityset_tests/test_plotting.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1998ec7...c17acd6. Read the comment docs.

@kmax12

kmax12 approved these changes Feb 14, 2019

Copy link
Member

kmax12 left a comment

LGTM

@gsheni gsheni merged commit 6a2e649 into master Feb 14, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.25%)
Details
codecov/project 96.33% (+0.08%) compared to 1998ec7
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the plot_fix branch Feb 14, 2019

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.